Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the scroll to modal in dashboard #1847

Merged
merged 6 commits into from
Sep 10, 2024

Conversation

abhishek-01k
Copy link
Collaborator

@abhishek-01k abhishek-01k commented Sep 9, 2024

Pull Request Template

#1845

Description

Added scrollbar to the opt In Modal

  • Problem/Feature:

Type of Change

  • Bug fix
  • New feature
  • Code refactor
  • Documentation update
  • Other (please describe):

Checklist

  • Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
    • Quick PR label added
  • Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
    • DO NOT Merge PR label added

Frontend Guidelines

Build & Testing

  • No errors in the build terminal
  • Engineer has tested the changes on their local environment
  • Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

  • Scrollbar for Opt In Modal
Screenshot 2024-09-10 at 11 35 41 AM

Additional Context

Review & Approvals

  • Self-review completed
  • Code review by at least one other engineer
  • Documentation updates if applicable

Notes

@abhishek-01k abhishek-01k self-assigned this Sep 9, 2024
Copy link

github-actions bot commented Sep 9, 2024

All looks good.

Copy link

github-actions bot commented Sep 9, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-09-10 07:21 UTC

Copy link

github-actions bot commented Sep 9, 2024

All looks good.

Copy link

All looks good.

@abhishek-01k abhishek-01k removed the request for review from rohitmalhotra1420 September 10, 2024 06:14
Copy link

All looks good.

Copy link

In the file src/common/components/ManageSettingsDropdown.tsx:

  1. There are missing closing braces } after the handleUpdateNotificationSettings function and handleOptOut function.
  2. updatedSettings is not defined in the handleSwitchChange function. It should be replaced with modifiedSettings.
  3. Inside the handleUpdateNotificationSettings function, it should return a value after calling the updateNotificationSettings function.
  4. RangeSlider component is used with props like startVal, endVal, defaultStartVal, and defaultEndVal, but these props are not defined in the input parameters of the RangeSlider component.
  5. The Box component is not closed properly after the RangeSlider rendering. It should be closed before the Separator.

Overall, the code seems to have some syntactical errors and missing logic. Kindly review and address these issues.

File src/common/components/NotificationSettingsDropdown.tsx is empty.

Please fill the code in src/common/components/NotificationSettingsDropdown.tsx file for further review.

Let me know if you need any more assistance.

@rohitmalhotra1420 rohitmalhotra1420 added the Quick PR A PR that can be approved before finishing a coffee label Sep 10, 2024
@rohitmalhotra1420 rohitmalhotra1420 merged commit 7fbf88e into main Sep 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Quick PR A PR that can be approved before finishing a coffee
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants